Change in vdsm[master]: image: placeholder optimization on preallocation

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: image: placeholder optimization on preallocation
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/image.py
Line 527:                     # we create the target as a sparse volume (since it will be
Line 528:                     # soon filled with the data coming from the copy) and then
Line 529:                     # we change its metadata back to the original value.
Line 530:                     if (volParams['prealloc'] == volume.PREALLOCATED_VOL
Line 531:                             and not destDom.lightweightPreallocation):
Now that I think of it, it might be better a different semantic: "supportsSparseness" and always use SPARSE_VOL when supported.
Line 532:                         tmpVolPreallocation = volume.SPARSE_VOL
Line 533:                     else:
Line 534:                         tmpVolPreallocation = volParams['prealloc']
Line 535:

--
To view, visit http://gerrit.ovirt.org/12692
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32811bd45320ef02bfc593a71dfdafc0b0550c7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli