Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
......................................................................
Patch Set 5:
(1 comment)
....................................................
File lib/vdsm/tool/lvm_deactivate_lvs.py
Line 135: return lv_attr[5] == "o"
Line 136:
Line 137:
Line 138: def deactivate_vg(vg):
Line 139: log("deactivating %s" % vg)
Logging go to stderr - this command as meaningful output.
Does it create any issue for the tool or for pre-start?
Line 140: rc, out, err = lvm("vgchange", "--available", "n", vg)
Line 141: if rc != 0:
Line 142: raise Error("Error deactivating %s: %s" % (vg, err))
Line 143:
--
To view, visit
http://gerrit.ovirt.org/20720
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Alon Bar-Lev
alonbl@redhat.com
Gerrit-Reviewer: Ayal Baron
abaron@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes