Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation ......................................................................
Patch Set 9: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44689/9/lib/vdsm/sslcompat.py File lib/vdsm/sslcompat.py:
Line 29: from . import m2cutils as sslutils Line 30: from .m2cutils import SSLSocket Line 31: from .m2cutils import SSLHandshakeDispatcher Line 32: _USED_M2C = True Line 33: except ImportError:
There can be difference in how we built vdsm and how we configured.
That's exactly the reason why I don't like this direction. its messed up - how the user should know if he installed rpm with m2c or not.. :/ Line 34: _log.warning('Configured m2crypto but not available falling back' Line 35: ' to ssl') Line 36: else: Line 37: # we need it to satisfy pyflakes