Dan Kenigsberg has posted comments on this change.
Change subject: Set exc_info=True when self.message is used in log.error for vds_bootstrap ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
sorry, I was probably unclear when I asked you to add exc_info=True.
.................................................... File vds_bootstrap/vds_bootstrap.py Line 539: logging.error(self.message, exc_info=True) this is not in an except: clause, so can cause logging of an unrelated exception.
Line 622: logging.error(self.message, exc_info=True) again, should be done only in except: clauses
Line 627: logging.error(self.message, exc_info=True) ditto
-- To view, visit http://gerrit.ovirt.org/945 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id5fa63d9809e5f7130e304eceede6d41a27a12a6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com