Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for PCI passthrough
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/22462/5//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2013-12-17 12:54:57 +0100
Line 4: Commit: Martin Polednik <mpoledni(a)redhat.com>
Line 5: CommitDate: 2013-12-20 13:04:09 +0100
Line 6:
Line 7: vdsm: add support for PCI passthrough
Is this really only for PCI? It seems that it could handle any other
type (
Correct, as long as libvirt allows the device to be passthrough'd it will
be available. I'll update the commit message later (if some code concerns arise to
reduce the number of patchsets)
Line 8:
Line 9: Adds basic support for PCI-passthrough that includes reporting
Line 10: available host devices in vdsCapabilities, reporting VM's attached
Line 11: host devices and creation of VM with such device attached using
http://gerrit.ovirt.org/#/c/22462/5/vdsm/vm.py
File vdsm/vm.py:
Line 1656: m.setAttrs(model=self.specParams['model'])
Line 1657: return m
Line 1658:
Line 1659:
Line 1660: class HostDevice(VmDevice):
We could start using the __slots__ for the new devices that we add.
Sure, but I'd like to keep the patch self-contained: if __slots__ are merged
before this patch is I'll do a rebase with __slots__ included, if it isn't the
device will be consistent with others for the time being.
Line 1661: def getXML(self):
Line 1662: """
Line 1663: Create domxml for a hostdev device.
Line 1664:
--
To view, visit
http://gerrit.ovirt.org/22462
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes