Adam Litke has posted comments on this change.
Change subject: Added gluster tag support in getAllTasks() ......................................................................
Patch Set 4: (1 inline comment)
.................................................... File vdsm/storage/taskManager.py Line 113: taskID) Line 114: self.log.debug("Return: %s", subRes) Line 115: return subRes Line 116: Line 117: def getAllTasks(self, tag=[]): In my opinion we should convert task to represent the tags as a proper list. That is probably more work though and we'd need to make sure that it didn't break any existing functionality.
Given the completely broken behavior of the old API, I doubt that changing tags to a list would break anything though. Line 118: """ Line 119: Return Tasks for all public tasks if param tag is empty, Line 120: else return tasks those tags are in param tag. Line 121: """
-- To view, visit http://gerrit.ovirt.org/7579 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9c765cbfebb5ba22f0d21efa04c824ea4daf6432 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shireesh Anjal sanjal@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server