From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: mailbox: Decrease the chance of checksum failures ......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/73078/2//COMMIT_MSG Commit Message:
Line 17: There is no way to write 4096 bytes atomically, so we cannot fix this Line 18: issue. But we can decrease the chance of the failure by doing one write Line 19: of 4096 bytes, instead of 8 writes of 512 bytes. There is still chance Line 20: of failure since writing on the remote storage is probably done using Line 21: 512 blocks, but the chance of reading incomplete write is much lower. I suspect that this may also improve performance on modern storage, where the sector size is 4096 ? Line 22: Line 23: Since both reading and writing was done using 512 bytes blocks, both Line 24: were modified to use 4096 block size. The SPM mailbox is already writing Line 25: replies using 4096 block size.