Dan Kenigsberg has posted comments on this change.
Change subject: fix getVmList 0 sdUUID error ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Could you move the Bugzilla bug to POST and a link to this patch? It should help other BZ readers to understand where this bug stands.
The code itself seems fine to me, but I do not understand the commit message at all.
.................................................... Commit Message Line 13: getting lock of storage.none/storage.0 I do not understand the commit message. Could you use multiple, short sentences?
-- To view, visit http://gerrit.ovirt.org/3560 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I27fe906e6738320279bc44f9736acaa97131d7ee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com