Nir Soffer has posted comments on this change.
Change subject: volume: move metadata dict creation to volume.py
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/28492/3/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 812: Teardown volume.
Line 813: If justme is false, the entire COW chain is teared down.
Line 814: """
Line 815: pass
Line 816:
This module uses mixedCase, so this function should be named parseMetadata. metadata2dict
is consistent with metadata2info, but the later is not consistent with the rest of the
module naming conventions. I don't like this style but consistency is important.
In another patch we should also remove the duplicate code writing the meta data in
blockVolume.py and fileVolume.py and move it to formatMetadata function in this module.
Line 817: def metadata2dict(self, meta):
Line 818: out = {}
Line 819: for l in meta:
Line 820: if l.startswith("EOF"):
--
To view, visit
http://gerrit.ovirt.org/28492
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c495d437fe327a4029fe1dae087d182ba6611b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes