Antoni Segura Puimedon has posted comments on this change.
Change subject: stats: report detailed VM down status
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
constants should go in UPPER_CASE
http://gerrit.ovirt.org/#/c/22631/7/vdsm/vm.py
File vdsm/vm.py:
Line 88: MigrationSucceeded = 4
Line 89: SaveStateSucceeded = 5
Line 90: AdminShutdown = 6
Line 91: UserShutdown = 7
Line 92: MigrationFailed = 8
All these are constants. They should be completely uppercase:
SUCCESS
GENERIC_ERROR
...
MIGRATION_FAILED
And I would probably not have a class for it but a module (for consistency with the error code declaration of vdsm/neterrors.py)
Line 93:
Line 94:
Line 95: def isVdsmImage(drive):
Line 96: """
--
To view, visit
http://gerrit.ovirt.org/22631
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon
asegurap@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Michal Skrivanek
michal.skrivanek@redhat.com
Gerrit-Reviewer: Saggi Mizrahi
smizrahi@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes