Assaf Muller has posted comments on this change.
Change subject: Add --run-again option to upgrades ......................................................................
Patch Set 1:
(3 comments)
.................................................... File lib/vdsm/tool/upgrade.py Line 117: self._detachUpgradeLog() Line 118: Line 119: Line 120: def _parse_args(): Line 121: parser = argparse.ArgumentParser('vdsm-tool') Done Line 122: parser.add_argument( Line 123: '--force', Line 124: dest='force', Line 125: default=False,
Line 125: default=False, Line 126: action='store_true', Line 127: help='Run the upgrade again, even if it was ran before', Line 128: ) Line 129: return parser.parse_args(sys.argv[2:]) Sorry I'm not following - The upgrades should and can only be called via vdsm-tool? Line 130: Line 131: Line 132: def upgrade(upgradeName): Line 133: """
.................................................... File lib/vdsm/tool/upgrade_300_networks.py Line 64: """ Line 65: networks = netinfo.networks() Line 66: bridges = netinfo.bridges() Line 67: Line 68: if isNeeded(networks, bridges): I wanted an option that could skip the upgrade file check, but wouldn't meddle with an upgrade's logic. I'll rename the option.