Zhou Zheng Sheng has posted comments on this change.
Change subject: make vdsmd.init.in adapt to both Fedora and Ubuntu ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/vdsmd.init.in Line 574: else Line 575: killproc -p $PIDFILE -d 2 Line 576: RETVAL=$? Line 577: [ "$RETVAL" -eq 0 ] && log_success_msg $"$prog stop" || log_failure_msg $"$prog stop" Line 578: [ "$RETVAL" -eq 0 ] && rm -f "LOCK_PATH/vdsmd" Oops. Miss a $ here. Line 579: fi Line 580: python @VDSMDIR@/hooks.pyc after_vdsm_stop Line 581: return $RETVAL Line 582: }
-- To view, visit http://gerrit.ovirt.org/13489 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I186743ed7fd345bf150047d4005818e1df3c07fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server