Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for TPM device passthrough ......................................................................
Patch Set 3: Code-Review-1
(2 comments)
-1 for the trailing spaces
http://gerrit.ovirt.org/#/c/20649/3/vdsm/vm.py File vdsm/vm.py:
Line 1823: </backend> Line 1824: </tpm> Line 1825: """ Line 1826: tpm = self.createXmlElem(self.device, None) Line 1827: tpm.setAttrs(**{'model': self.specParams['model']}) why do we need here the splat operator (**{}) and not a plain simple parameter passing like
model=self.specParams['model']
? Line 1828: backend = tpm.appendChildWithArgs('backend', Line 1829: type=self.specParams['mode']) Line 1830: backend.appendChildWithArgs('device', Line 1831: path=self.specParams['path'])
http://gerrit.ovirt.org/#/c/20649/3/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json:
Line 2659: ## Line 2660: {'type': 'VmTpmDeviceSpecParams', Line 2661: 'data': {'model': 'VmTpmDeviceModel', Line 2662: 'path': 'str', Line 2663: 'mode': 'VmTpmDeviceMode'}} trailing spaces Line 2664: Line 2665: ## Line 2666: # @VmTpmDevice: Line 2667: #