Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.ovirt.org/#/c/24814/1//COMMIT_MSG Commit Message:
Line 8: Line 9: VDSMBRIDGE is a historical macro holding the "management bridge" of Line 10: Vdsm. Nowadays, this bridge may well not exist as management network are Line 11: better kept bridge-less. The concept of "management bridge" is currently Line 12: used only within vdsm-reg, and only when it needs to register to a legcay s/legcay/legacy/ Line 13: oVirt-Engine that expects the bridge to exist. Line 14: Line 15: This patch hides the unneeded macro within vdsm-reg, to be completely Line 16: dropped when vdsm-reg is replaced by an ovirt-node-register utility.
http://gerrit.ovirt.org/#/c/24814/1/vdsm_reg/deployUtil.py.in File vdsm_reg/deployUtil.py.in:
Line 85: ERR_NO_ROUTE = 7 Line 86: SCRIPT_NAME_ADD = "addNetwork" Line 87: SCRIPT_NAME_DEL = "delNetwork" Line 88: IFACE_CONFIG = "/etc/sysconfig/network-scripts/ifcfg-" Line 89: MGT_BRIDGE_NAME = "ovirtmgmt" Will this variable be changed by a downstream patch? It makes sense to do so and I approve of that. Line 90: REMOTE_SSH_KEY_FILE = ('/engine.ssh.key.txt',) Line 91: CORE_DUMP_PATH = '/var/lib/vdsm/core' Line 92: CORE_PATTERN = '/proc/sys/kernel/core_pattern' Line 93: XML_QUOTES = {