Nir Soffer has posted comments on this change.
Change subject: vm: Cleaner vm stats thread initialization ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/39299/1/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 1268: if self._destroyed: Line 1269: return Line 1270: toSave = self.status() Line 1271: toSave['startTime'] = self._startTime Line 1272: if self.lastStatus != vmstatus.DOWN: It was not clear why we check self._vmStats here do we want to know if we started it? Line 1273: guestInfo = self.guestAgent.getGuestInfo() Line 1274: toSave['username'] = guestInfo['username'] Line 1275: toSave['guestIPs'] = guestInfo['guestIPs'] Line 1276: toSave['guestFQDN'] = guestInfo['guestFQDN']