Ayal Baron has posted comments on this change.
Change subject: fix circular reference of storage pool
......................................................................
Patch Set 2: I would prefer that you didn't submit this
Question is can't we just pass a weakref to self._upgradeCallback to avoid creation of
the circular reference to begin with.
e.g.
self.domainMonitor.onDomainConnectivityStateChange.register(weakref.ref(self._upgradeCallback))
(but need to see how to handle unregister in this case).
On the face of it, it looks much simpler this way...
--
To view, visit
http://gerrit.ovirt.org/3242
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2993b0ad8d85898ca86008f7056973ff493e8de
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>