Shu Ming has posted comments on this change.
Change subject: make misc.pgrep for general usage ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File vdsm/storage/blockSD.py Line 1087: raise Line 1088: Line 1089: for umountPid in umountPids: Line 1090: try: Line 1091: state = utils.pidStat(umountPid)['state'] I think you need another patch for this change. So as the other similar fixes. Line 1092: mountPoint = misc.getCmdArgs(umountPid)[-1] Line 1093: except: Line 1094: # Process probably exited Line 1095: continue
.................................................... File vdsm/utils.py Line 212: procNameEnd = statline.rfind(")") Line 213: res.append(int(statline[:procNameStart])) Line 214: res.append(statline[procNameStart + 1:procNameEnd]) Line 215: args = statline[procNameEnd + 2:].split() Line 216: res.append(args[0]) In case the evolving of the format of the proc file syste, would you please add some comments about how statName tuple is mapped to the res list? Line 217: res.extend([int(item) for item in args[1:]]) Line 218: return dict(zip(statName, tuple(res))) Line 219: Line 220:
-- To view, visit http://gerrit.ovirt.org/11033 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2034b04a4787d2f222cb98dfe3ffcdbb2a94ebb8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server