Antoni Segura Puimedon has posted comments on this change.
Change subject: build: Forbid bare exepct ......................................................................
Patch Set 1:
(1 comment)
.................................................... File Makefile.am Line 78: SKIP_PYFLAKES_ERR = "./vdsm/storage/lvm.py.*: list comprehension redefines \ Line 79: 'lv' from line .*" Line 80: Line 81: check-local: Line 82: if git show | grep 'except:'; then \ grep returns 0 when found and 1 otherwise. Shouldn't you exit and show error in the "0" case. Line 83: echo "error: empty except: is not allowed!"; \ Line 84: exit 1; \ Line 85: fi Line 86: find . -path './.git' -prune -type f -o \