Gustavo Frederico Temple Pedrosa has posted comments on this change.
Change subject: xmlrpc: [Fix] Use correct base class for parsing request ......................................................................
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/25524/2//COMMIT_MSG Commit Message:
Line 9: Previously we always used SecureXMLRPCServer.parse_request, even when Line 10: using SimpleXMLRPCServer. That happened to work since both inherit Line 11: parse_request from BaseHTTPServer. This patch use the correct base Line 12: class, so if one of them will override parse_request, we use the correct Line 13: method.
Please add note that without this fix ssl=false does not work on python 2.7
Done Line 14: Line 15: Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f Line 16: Signed-off-by: Gustavo Pedrosa gustavo.pedrosa@eldorado.org.br
Line 11: parse_request from BaseHTTPServer. This patch use the correct base Line 12: class, so if one of them will override parse_request, we use the correct Line 13: method. Line 14: Line 15: Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f
Add Bug-Url: https://bugzilla.redhat.com/xxxxxx
Done Line 16: Signed-off-by: Gustavo Pedrosa gustavo.pedrosa@eldorado.org.br
Line 13: method. Line 14: Line 15: Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f Line 16: Signed-off-by: Gustavo Pedrosa gustavo.pedrosa@eldorado.org.br Line 17: Reviewed-on: http://gerrit.ovirt.org/25524
Reviewed-on should point to http://gerrit.ovirt.org/#/c/24289/
Done