Francesco Romani has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
......................................................................
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/38425/14/vdsm/API.py
File vdsm/API.py:
Line 1379: logging.warning('Setting loglevel to %s (%d)', level,
log_level)
Line 1380: [fileHandler] = [h for h in handlers if
Line 1381: isinstance(h, logging.FileHandler)]
Line 1382: fileHandler.setLevel(int(level))
Line 1383: return response.success()
I think we should create lib/vdsm/logging module and keep API as a
bridge c
rebasing and reordering the series to have the move first.
Line 1384: else:
Line 1385: return response.error('unavail')
Line 1386:
Line 1387: # VM-related functions
--
To view, visit
https://gerrit.ovirt.org/38425
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaddbb12d13bdbaa7a02255ab209da11e42d2ea97
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes