Dan Kenigsberg has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain ......................................................................
Patch Set 5:
(1 comment)
SPM never promised unintermitted visibility to all storage domains. Vdsm revokes its own spm role only when the master domain is lost - it is Engine's responsibility to decide whether an SPM with partial visibility to other storage domains should survive.
With this patch, this is kept also on spm start.
http://gerrit.ovirt.org/#/c/25424/5/vdsm/storage/sp.py File vdsm/storage/sp.py:
Line 210: Line 211: if domain.getDomainRole() == sd.REGULAR_DOMAIN: Line 212: continue Line 213: Line 214: self._backend.setDomainRegularRole(domain) if produce() succeeds, but connection to storage is lost a bit later, setDomainRegularRole's failure would fail spmStart. I suppose that this can be fixed in a future patch. Line 215: Line 216: @unsecured Line 217: def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None): Line 218: """