Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
......................................................................
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/24/vdsm.spec.in
File vdsm.spec.in:
Line 614: sed -i -e 's/^software_version =.*/software_version = "'"${baseversion}"'"/' \
Line 615: -e 's/^raw_version_revision =.*/raw_version_revision = "'"${rawversion}"'"/' \
Line 616: -e 's/^software_revision =.*/software_revision = "'"${baserelease}"'"/' vdsm/dsaversion.py
Line 617:
Line 618: sed -i -e 's/@SSL_IMPLEMENTATION@/m2c/g' lib/vdsm/config.py
I don't mind doing this for the mean while. A future patch can make it a pr
Please take a look at previous patch set. Yaniv asked to remove this flag.
Line 619:
Line 620: %install
Line 621: rm -rf %{buildroot}
Line 622: make DESTDIR=%{buildroot} install
--
To view, visit
https://gerrit.ovirt.org/44689
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Ondřej Svoboda
osvoboda@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Sandro Bonazzola
sbonazzo@redhat.com
Gerrit-Reviewer: Simone Tiraboschi
stirabos@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-HasComments: Yes