Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
......................................................................
Patch Set 9: Code-Review+1
(3 comments)
Looks ok, just a few minor notes.
http://gerrit.ovirt.org/#/c/22462/9/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 246: self.assertEqual(status, SUCCESS, msg)
Line 247: exists = False
Line 248: for device in stats['devices']:
Line 249: if device['type'] == 'hostdev':
Line 250: exists = True
please consider to replace the above four lines with
self.assertTrue(any(device['type'] == 'hostdev' for device
in stats['devices']))
Line 251:
Line 252: self.assertTrue(exists, 'Device has not beed attached to
VM!')
Line 253:
Line 254: @requireKVM
http://gerrit.ovirt.org/#/c/22462/9/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 1137: # network configuration
Line 1138: #
Line 1139: # @rngSources: Sources of entropy available at this host
Line 1140: #
Line 1141: # @hostDevices: List of @HostDevice available at this host
Please add the
(new in version WHATEVER)
(4.15?) annotation
Line 1142: #
Line 1143: # @numaNodes: Information about host numa topology
Line 1144: #
Line 1145: # @numaNodeDistance: Distance information between each two numa nodes
Line 2112: # @smartcard: A smartcard device
Line 2113: #
Line 2114: # @rng: A rng device
Line 2115: #
Line 2116: # @hostdev: A host device
same as above
Line 2117: #
Line 2118: # @graphics: The graphics device
Line 2119: # (new in version 4.15.0)
Line 2120: #
--
To view, visit
http://gerrit.ovirt.org/22462
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes