Nir Soffer has posted comments on this change.
Change subject: hsm: encapsulate devPath in appropriateDevice ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24406/1/vdsm/clientIF.py File vdsm/clientIF.py:
Line 270: # Update size for LUN volume Line 271: drive["truesize"] = res['truesize'] Line 272: drive["apparentsize"] = res['apparentsize'] Line 273: Line 274: volPath = res['devPath'] Why not use "path" - just like prepareImage used for PDIV format?
We want to unify the names (appropriateDevice -> prepareDevice), and having both methods return a "path" key will make them more consistent and easier to use. Line 275: Line 276: # UUID drive format Line 277: elif "UUID" in drive: Line 278: volPath = self._getUUIDSpecPath(drive["UUID"])