Change in vdsm[master]: lvm: Fail loudly if called with unexpected input

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: lvm: Fail loudly if called with unexpected input
......................................................................

Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/37329/3/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:

Line 724:                 else:
Line 725:                     raise
Line 726: 
Line 727:     # We must be very carefull here; any value execpt True or False is a user
Line 728:     # error.
> If this comes from the xml/json rpc API it should be validated there. Inter

I agree that we should not validate types in general, but in rare places we *require* certain types, we must validate them.
Line 729:     if type(force) != bool:
Line 730:         raise ValueError("Invalid value for 'force': %r" % force)
Line 731: 
Line 732:     if force is True: