Mark Wu has uploaded a new change for review.
Change subject: Don't monitor the usage of '/var/run/vdsm' in diskStats ......................................................................
Don't monitor the usage of '/var/run/vdsm' in diskStats
Engine raises a warning that free space in /var/run/vdsm is less than 1GB. But actually, '/var/run' is mounted as a tmpfs. By default, the maximum size is half of the total physical memory. The warning is misleading because user could find it still has a lot of free space on the disk filesystem. And 1GB shouldn't be a low threshold for memory. So we needn't monitor the usage of '/var/run/vdsm' in 'diskStats' since it could be covered by memory usage monitoring.
Bug-uri: https://bugzilla.redhat.com/show_bug.cgi?id=906788 Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm/utils.py 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/11675/1
diff --git a/vdsm/utils.py b/vdsm/utils.py index 35338a0..57c3616 100644 --- a/vdsm/utils.py +++ b/vdsm/utils.py @@ -231,8 +231,7 @@
Contains the sate of the host in the time of initialization. """ - MONITORED_PATHS = ['/tmp', '/var/log', '/var/log/core', - constants.P_VDSM_RUN] + MONITORED_PATHS = ['/tmp', '/var/log', '/var/log/core']
def _getDiskStats(self): d = {}
-- To view, visit http://gerrit.ovirt.org/11675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com