Federico Simoncelli has posted comments on this change.
Change subject: vm: discover volume path from xml definition ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24202/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py:
Line 3219: # Filter volumes related to this image Line 3220: imgVolumes = sd.getVolsOfImage(allVols, imgUUID).keys() Line 3221: imgPath = dom.activateVolumes(imgUUID, imgVolumes) Line 3222: if spUUID and spUUID != sd.BLANK_UUID: Line 3223: runImgPath = dom.linkBCImage(imgUUID, imgPath)
I see that the order was changed :-). The question is why?
Yeah sorry for this, I changed the order because the required argument here is imgUUID. The additional imgPath argument is in the interface only to satisfy one of the specific implementations (block domains). I think we can plan to remove it later on. I'll try to add a comment on this in the commit message. Line 3224: else: Line 3225: runImgPath = imgPath Line 3226: Line 3227: leafPath = os.path.join(runImgPath, leafUUID)