Federico Simoncelli has posted comments on this change.
Change subject: storage: kill ongoing operations on exit ......................................................................
Patch Set 1:
(1 comment)
.................................................... File lib/vdsm/utils.py Line 517: return [l[:-1] if l.endswith('\n') else l for l in lines] Line 518: Line 519: Line 520: def watchCmd(command, stop, cwd=None, data=None, recoveryCallback=None, Line 521: nice=None, ioclass=None, execCmdLogger=logging.root, right, but the other mistake is in 'execCmd' where it should be False by default. Line 522: killOnExit=False): Line 523: """ Line 524: Executes an external command, optionally via sudo with stop abilities. Line 525: """