Nir Soffer has posted comments on this change.
Change subject: utils: Faster version of list2cmdline
......................................................................
Patch Set 2:
Alon, we do use args to run subprocess and we do not use shell=True, so there is no security issue here.
We use subprocess.list2cmdline to write the commands we run to the log. This make it very easy to debug the system by coying commands that vdsm run from the log and running them in the shell.
The original function is little expensive, and this patch suggest to to replace it with a quicker version.
I hope it is more clear now.
--
To view, visit
http://gerrit.ovirt.org/27548
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc7819c126fe51cc068cc6f9f85b1002878385b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Alon Bar-Lev
alonbl@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Saggi Mizrahi
smizrahi@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No