Change in vdsm[master]: [WIP] Added getStorageDevices verb.

Eduardo has posted comments on this change.

Change subject: [WIP] Added getStorageDevices verb.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

We have a lot of duplicate functionality here,
Let's reuse and unify the functions of this patch.
A lot of similar functions are in the vdsm.storage.devicemapper and vdsm.storage.lvm modules, etc.
May be we can modify the output of getDeviceList adding the extra keys? Actual managers will ignore this new info.

Mr Bala, can we help you with the getDeviceList you are experiencing?

....................................................
File vdsm/storage_device_utils.py
Line 38:         return os.path.normpath(name)
Please use devicemapper and multipath module functions

Line 92: 
Please use the lvm module.

--
To view, visit http://gerrit.ovirt.org/3725
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cb217321a7a8dfcd1b507c7cba2888f08612207
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir