Dan Kenigsberg has posted comments on this change.
Change subject: sriov: Make the hook safe for concurrency ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Toni, this hook assumes that someone, most probably a human, has pinned the VM to a host, and assigned a host device to its vnic(s).
In my opinion, the hook does not need to protect against the possibility of two VMs that wrongly share the same hostdevice, and are being started at the same time.
-- To view, visit http://gerrit.ovirt.org/13641 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2c6ad7f2ee53911312700396000e0aca07a917e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Yasny dyasny@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server