Change in vdsm[master]: Avoid template deactivation and lock.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Avoid template deactivation and lock.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(4 inline comments)

....................................................
Commit Message
Line 8: 
describe the intention:
We would like to avoid taking re-acquiring resources for Vm's disks on Vdsm restart.

However, we want to keep the template active after it is used by an spm verb. Instead of counting the references to the template and deactivating when the refcount is 0, we leak the activation on first use and never deactivate the template.

this may lead to performance hit once we have thousands of templates.

....................................................
File vdsm/storage/blockVolume.py
Line 408:         # Will log a false positive error for templates.
if volUUID is a template

Line 425:                 # A parent from other image is a template.
other->another

Line 489:             return tags[tagPrefix[:-1]]
into previous patch

--
To view, visit http://gerrit.ovirt.org/863
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieedf863ac967f34405f038201bac324c52fbbe89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg