Dan Kenigsberg has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG ......................................................................
Patch Set 17:
(2 comments)
.................................................... Commit Message Line 15: devices are filtered . The only way to invalidate filter now is flush LvmCache. Line 16: To avoid perfomance issues the patch introduces public method for filter invalidation Line 17: and calls it from the getDevicesVisibility. As far as getDevicesVisibility Line 18: is called to all added devices this allows to reload filters every time Line 19: after new devices has been mapped but before vgscan. sure! but according to Nir's explanation, we expect it to be called on the spm! Line 20: Line 21: Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Line 22: Bugzilla-Url: https://bugzilla.redhat.com/1022976
Line 16: To avoid perfomance issues the patch introduces public method for filter invalidation Line 17: and calls it from the getDevicesVisibility. As far as getDevicesVisibility Line 18: is called to all added devices this allows to reload filters every time Line 19: after new devices has been mapped but before vgscan. Line 20: I'm missing an explanation on why this cannot be done in the begining of extendStorageDomain verb, and what happens on other hosts in the cluster, which would have stale filters as well. Line 21: Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Line 22: Bugzilla-Url: https://bugzilla.redhat.com/1022976