Change in vdsm[master]: vm: Support for non-ascii vm name

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vm: Support for non-ascii vm name
......................................................................


Patch Set 1: Code-Review-1

I am really surprised that Engine passes non-unicode vmName. The ancient virt/vm.py code
assumes that

            pid = supervdsm.getProxy().getVmPid(
                self.name.encode('utf-8'))

and was tested in the (distant) past.

+1 for fixing this in Engine.

-- 
To view, visit https://gerrit.ovirt.org/48570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2386c0f98aeb8161feaf19c2862be229f73eb0df
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com&gt;
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No