Yaniv Bronhaim has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes ......................................................................
Patch Set 16:
(1 comment)
.................................................... File init/vdsmd_init_common.sh.in Line 180: } Line 181: Line 182: task_lvm_deactivate_lvs(){ Line 183: "$VDSM_TOOL" lvm-deactivate-lvs Line 184: } FINALLY ! :)
now I can say that you can just put here:
task_lvm_deactivate_lvs(){ local vgs_info=$(/sbin/lvm vgs --noheadings -o vg_name,tags) if [ $? -ne 0 ]; then log_failure_msg "$prog: error checking vgs" return 1 fi $(echo $vgs_info | /bin/awk '/MDT_TYPE=FCP/ {print $1}') || return 1 [ ! lvm vgchange -a n $vdsm_vgs ] || return 1 return 0 }
its quite more simple .. and anyhow, you plan to use it only here. no? Line 185: #### pre-start tasks end #### Line 186: Line 187: Line 188: #### post-stop tasks ####