Nir Soffer has posted comments on this change.
Change subject: introducing capabillity to stream data to image ......................................................................
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/23281/9//COMMIT_MSG Commit Message:
Line 40: -- Mandatory custom headers: Line 41: *X-Storage-Pool-Id : mandatory for succesfull execution Line 42: *X-Storage-Domain-Id: mandatory for succesfull execution Line 43: *X-Image-Id: mandatory for succesfull execution Line 44: *X-Volume-Id: mandatory for succesfull execution
I don't agree with removing it from here, when looking for/in the patch it'
The headers required by the put request are uninteresting implementation details, so they do not add any value to the commit message. They do add value to when they are located near the implementation.
Think about someone trying to understand what headers are required for the PUT method. What would be the best place for this documentation? Line 45: Line 46: Change-Id: I768b84799ed9fb2769c6d4240519d036f8988b99