Change in vdsm[master]: hook: spiceoptions: To provide spice option attributes to vm

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: hook: spiceoptions: To provide spice option attributes to vm
......................................................................

Patch Set 3: Code-Review-1

(2 comments)

partial review

....................................................
File vdsm_hooks/spiceoptions/before_vm_start.py
Line 42: strModeList = ['filter', 'all', 'off']
Line 43: 
Line 44: mouseModeList = ['server', 'client']
Line 45: 
Line 46: spiceDict = {'image': {'compression': imageCompList},
these are all CONSTANTS, and should be named as such.
Line 47:              'jpeg': {'compression': jpegCompList},
Line 48:              'streaming': {'mode': strModeList},
Line 49:              'mouse': {'mode': mouseModeList},
Line 50:              'clipboard': {'copypaste': copyPaste}}

Line 104:         sys.stderr.write('\n No Valid Element created for graphic device :%s\n'
Line 105:                          % (attrname))
Line 106: 
Line 107: 
Line 108: if 'spiceoptions' in os.environ:
please split to main() and test() functions, and use hooking.py's hook_exit().
Line 109:     try:
Line 110:         attrName = ''
Line 111:         attrVal = ''
Line 112:         attrOpt = ''