Nir Soffer has posted comments on this change.
Change subject: utils: Faster version of list2cmdline ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27548/1/lib/vdsm/utils.py File lib/vdsm/utils.py:
Line 699: if not printable: Line 700: printable = command Line 701: Line 702: cmdline = repr(list2cmdline(printable)) Line 703: execCmdLogger.debug("%s (cwd %s)", cmdline, cwd)
with %r, repr() would not be called at all (if log level is higher then DEB
Correct, I missed that line with the repr(). I don't think this will make any difference but it does not make sense to use repr in this context. Line 704: Line 705: p = CPopen(command, close_fds=True, cwd=cwd, env=env, Line 706: deathSignal=deathSignal, childUmask=childUmask) Line 707: p = AsyncProc(p)