Alon Bar-Lev has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
......................................................................
Patch Set 1:
1. if connection of new volume group can happen post boot, how come adding anything to init script solves the issue?
2. consider using udev rule, maybe it will solve the issue post boot as well.
3. consider that on startup vdsm will perform whatever action you do here via svdsm, doing so in startup is similar to doing this on boot.
4. if init.d operation is required use pre-start task of the vdsmd service.
Thanks!
--
To view, visit
http://gerrit.ovirt.org/20720
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Alon Bar-Lev
alonbl@redhat.com
Gerrit-Reviewer: Ayal Baron
abaron@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No