Dan Kenigsberg has posted comments on this change.
Change subject: add/del network - add bridgesless network ......................................................................
Patch Set 9: (6 inline comments)
minor comments and questions... review unfinished. I wish we could talk about this patch.
.................................................... File vdsm/clientIF.py Line 118: configNetwork.createLibvirtNetwork(network, True, None) having argument names here would increase readability.
.................................................... File vdsm_cli/vdsClient.py Line 1424: for k in ['bridge', 'vlan', 'bond', 'nics', ]: do you really want to own this line in `git blame`? ;-)
.................................................... File vdsm/netinfo.py Line 26: from fnmatch import fnmatch imports from stdlib should come first. libvirtconnection later.
Line 59: Get dict of birdgeless networks I don't see anything here which is specific to bridgeless network. Cannot this be safely renamed to "networks()" ?
Line 348: nics = [] getNicsVlanAndBondingForBridgeless() looks like a repetition of this code. Cannot this be unified with something like
if bridged: ports = self.networks[network]['ports'] else: ports = bridgeless()[network]
Line 354: port = nic unrelated to your patch, but this looks very bad - how come are we changing port within the iteration??
-- To view, visit http://gerrit.ovirt.org/848 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id7a3efea92312ac628e0373a5c29fbb1669058f4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com