Dan Kenigsberg has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 5: Verified; Looks good to me, but someone else must approve
(2 inline comments)
but please consider the two comments within.
....................................................
File tests/parted_utils_tests.py
Line 47: os.close(tempFd)
ok, if the docs says so... I still think it is ugly to touch the fd w/o purpose. how about
tempfile.NamedTemporaryFile(delete=false) ?
Line 52: self.assertTrue(rc == 0)
assertEquals() gives even more info on failure. but it's your call.
--
To view, visit
http://gerrit.ovirt.org/3386
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>