Dan Kenigsberg has posted comments on this change.
Change subject: vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to it second time. ......................................................................
Patch Set 5: Code-Review-1
(1 comment)
.................................................... Commit Message Line 3: AuthorDate: 2013-10-25 11:10:39 +0200 Line 4: Commit: Pavel Zhukov pzhukov@redhat.com Line 5: CommitDate: 2013-10-25 13:00:55 +0200 Line 6: Line 7: vgscan doesn't return nonzero return code if one or more phisycal please have a short line at the top, separated by a newline.
your current subject has double negation and is hard to comprehend. Please explain the problem at hand and how this patch solves it. Line 8: volumes are filtered (missed). We should check vg before raising of Line 9: the exception. chkVG itself raises storageAccessError if failed, so Line 10: selftest doesn't have to it second time. Line 11: