Francesco Romani has posted comments on this change.
Change subject: caps:Collect numa infomation ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
looks ok but I'd like to see some unit tests for this new code.
http://gerrit.ovirt.org/#/c/23703/1//COMMIT_MSG Commit Message:
Line 7: infomation spacing?
http://gerrit.ovirt.org/#/c/23703/1/vdsm/caps.py File vdsm/caps.py:
Line 163: Line 164: return topology Line 165: Line 166: Line 167: def _getNumaTopology(): Please check if this can be memoized safely (I think it can) with @utils.memoized Line 168: capabilities = _getCapsXMLStr() Line 169: caps = minidom.parseString(capabilities) Line 170: host = caps.getElementsByTagName('host')[0] Line 171: cells = host.getElementsByTagName('cells')[0]
Line 184: ) please add some unit tests in tests/capsTests.py; they also will document the expected format of the output of this new function.