Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Do not mix local time and UTC, improve tests ......................................................................
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/24192/4/tests/functional/networkTests.py File tests/functional/networkTests.py:
Line 1702: Line 1703: with namedTemporaryDir(dir='/var/lib/dhclient') as tmpDir: Line 1704: confFile = os.path.join(tmpDir, 'test.conf') Line 1705: leaseFile = os.path.join(tmpDir, 'test.lease') Line 1706: pidFile = os.path.join(tmpDir, 'test.pid')
dhcp.runDhclient() is tightly bound to its only caller. If pidFile did not
I preferred to keep this refactoring to a follow up patch but I think we can let the current version be. Line 1707: Line 1708: with open(confFile, 'w') as f: Line 1709: f.write('db-time-format {0};'.format(dateFormat)) Line 1710:
http://gerrit.ovirt.org/#/c/24192/4/tests/netinfoTests.py File tests/netinfoTests.py:
Line 301: ' interface "valid";\n' Line 302: ' expire {0:%w %Y/%m/%d %H:%M:%S};\n' Line 303: '}}\n' Line 304: 'lease {{\n' # in an actual lease file, Line 305: ' interface "valid2";\n' # human-readable date follows:
Would it be acceptable to include these fixed comments in the string and ma
Yeah, a static comment is good. Line 306: ' expire epoch {1:.0f};\n' Line 307: # expire epoch 2117041460; # Sat Jan 31 20:04:20 2037 Line 308: '}}\n' Line 309: 'lease {{\n'