Change in vdsm[master]: forceVMstart: Initial commit

Yaniv Bronhaim has posted comments on this change.

Change subject: forceVMstart: Initial commit
......................................................................

Patch Set 3: (2 inline comments)

....................................................
Commit Message
Line 7: forceVMstart: Initial commit
Line 8: 
Line 9: forceVMstart is a tool for gathering information for a VM using locally
Line 10: available xml files on SPM in order to manually start it in the event of
Line 11: RHEV-M not being available
why don't you add cli command for that instead of external tool?
Line 12: 
Line 13: Signed-off-by: Pablo

....................................................
File contrib/forceVMstart.py
Line 89:         return 0
Line 90: 
Line 91:     def checkRoot(self):
Line 92:         """check if the user running the script is root"""
Line 93:         if os.geteuid() != 0:
instead of kind of function I would write assert(os.geteuid() == 0, 'sudo it')
Line 94:             print "You must be root to run this script."
Line 95:             sys.exit(2)
Line 96: 
Line 97:     def getIpManagementIP(self):

--
To view, visit http://gerrit.ovirt.org/9473
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a70b31ce0730194880406701316f219c9f92ceb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pablo Iranzo Gómez 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Lee Yarwood 
Gerrit-Reviewer: Pablo Iranzo Gómez 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server