Hans De Goede has posted comments on this change.
Change subject: Add support for redir devices
......................................................................
Patch Set 2:
WRT specParams, I believe that the engine then just needs to be changed to pass parameters
which are now inside SpecParams at the same "dict level" as type and address, I
see no need for this nested dict non sense.
To be completely honest, I think specParams is madness, and the madness needs to be
stopped ASAP. A decision has been made to go with libvirt as direct manager of the vms and
vdsm as an agent between libvirt and ovirt-engine.
Since the decision to use libvirt has been made a long time ago, it no longer makes any
sense to have an ovirt private "dialect" for specifying vm parameters / devices.
I strongly believe that the xmlrpc structure of the create parameters should be identical
to the libvirt xml structure. Any translation done by vdsm will only serve to confuse
users trying to figure out the mapping between the create params and the libxml vdsm, as
well as introduce a whole now class of bugs which we can do without.
--
To view, visit
http://gerrit.ovirt.org/4133
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia91922a0f34cb4b32efa2c6397d13fe59aec04e7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Hans De Goede <hdegoede(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>