Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
......................................................................
Patch Set 8:
Changes:
- Remove module documentation
- Remove debug logs
- Prefix private names with _
- Raise RuntimeError on error and return 0 on success
- Merge deactivate_vg and deactivate_lv, since the difference was confusing, and it is uninteresting implementation detail
- When deactivating multiple lvs, call lvchange with all lvs instead of multiple calls.
- Remove some pointless constants
--
To view, visit
http://gerrit.ovirt.org/20720
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Alon Bar-Lev
alonbl@redhat.com
Gerrit-Reviewer: Ayal Baron
abaron@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No