Bala.FA has posted comments on this change.
Change subject: [WIP] Added getStorageDevices verb. ......................................................................
Patch Set 1: (2 inline comments)
It would be good to have getDeviceList (or something else) to populate these values with ignoring unwanted keys by respective managers.
Regarding non-working getDeviceList, could you tell me how I can run this verb? I ran 'vdsClient localhost getDeviceList' returns empty list for me.
.................................................... File vdsm/storage_device_utils.py Line 38: return os.path.normpath(name) I will check those modules
Line 92: I was trying to use the module, but relationship of pv/vg/lv are not stored in. I will check it once again and get back to you exactly
-- To view, visit http://gerrit.ovirt.org/3725 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2cb217321a7a8dfcd1b507c7cba2888f08612207 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com