Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Faster version of list2cmdline ......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/27548/2/lib/vdsm/utils.py File lib/vdsm/utils.py:
Line 659: arg = arg.replace("'", "'") Line 660: if ' ' in arg: Line 661: arg = "'" + arg + "'" Line 662: parts.append(arg) Line 663: return ' '.join(parts)
did you compare the cpu usage with this implementation ?
oh.. forgot the commit message part after reading your long description here Line 664: Line 665: Line 666: def execCmd(command, sudo=False, cwd=None, data=None, raw=False, logErr=True, Line 667: printable=None, env=None, sync=True, nice=None, ioclass=None,