Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes ......................................................................
Patch Set 7:
I can re-implement this in shell and put this in vdsmd_init_common.sh, and then create another patch using same or similar shell script for downstream, but this will be more work and will be harder to test and maintain.
It won't be harder to maintain if I looking into the future. You ask people to maintain something that is not natural only because you want to save you work of backporting a patch one time? I do not understand.
Looking into the future, we may find a bug in the deactivation code, and then we would have to fix both upstream copy and downstream copy. So not only we have more work now, we will have more work in the future.
And of course adding this amount of logic to vdsmd_init_common.sh does not makes sense. This script already calls either vsdm-tool verbs or run other Python scritps like vdsm-restore-net-config.
I think that same solution used for vdsm-restore-net-config is what we need here.